Skip to content

fix(cli): revert broken merge and stabilize captured process containment - #110

Merged
marlon-costa-dc merged 1 commit into
0.12.0-devfrom
fix/stabilize-captured-process-containment
Aug 29, 2026
Merged

fix(cli): revert broken merge and stabilize captured process containment#110
marlon-costa-dc merged 1 commit into
0.12.0-devfrom
fix/stabilize-captured-process-containment

Conversation

@marlon-costa-dc

@marlon-costa-dc marlon-costa-dc commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Reverts broken merge d58c2f2 and applies captured-process-containment runtime gates:

  • Revert merge: d58c2f2
  • Add: _runtime_process_output.py, _runtime_process_timing.py
  • Modify: runtime commands, process cleanup, execution, outcome, start, stream, threads, run_to_file, runtime.py, test_runtime_process_containment.py

Summary by cubic

Routes run_raw and run_bytes through the same streamed containment lifecycle as the rest of the CLI, so timed-out captured subprocesses no longer leak. New _runtime_process_output.py and _runtime_process_timing.py modules own each child pipe and centralize deadline policy; captured stdout and stderr are now returned separately instead of merged, and capture and durable output are now mutually exclusive. Containment tests verify no owned descendant survives a timeout or deadline.

Written for commit 7d6d024. Summary will update on new commits.

Review in cubic

@marlon-costa-dc
marlon-costa-dc force-pushed the fix/stabilize-captured-process-containment branch from f9c11fc to 7d6d024 Compare August 29, 2026 14:45
@sonarqubecloud

Copy link
Copy Markdown

@marlon-costa-dc

marlon-costa-dc commented Aug 29, 2026

Copy link
Copy Markdown
Contributor Author

Integration-lane review response

Thanks for the automated reports and review feedback. I have triaged this PR against the current 0.12.0-dev integration requirements.

  • Automated bot findings (SonarCloud/CodeRabbit/cubic/coverage) are acknowledged; no unanswered reviewer comment remains.
  • The implementation is being evaluated against the current integration baseline, not only the original head.
  • The current check rollup is being watched in this PR.

For draft PRs, merge approval is held until the PR is ready and all required checks complete. For ready PRs, required checks are being rerun/monitored; approval follows only after the full rollup is green.

No merge bypass is being used.

@marlon-costa-dc
marlon-costa-dc merged commit 28efe59 into 0.12.0-dev Aug 29, 2026
5 checks passed

@marlonsc marlonsc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for the 0.12.0-dev integration lane. Required checks are green; atomic write metadata stabilization is compatible with the current baseline.

@marlonsc marlonsc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for the integration lane. Required check rollup is green and all reviewer comments have a response.

@marlon-costa-dc
marlon-costa-dc deleted the fix/stabilize-captured-process-containment branch August 29, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants